1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/getkey.cpp

    From Rob Swindell@VERT to Git commit to sbbs/master on Thu Nov 5 00:02:18 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/688b566bd32ddb4bee07d60e
    Modified Files:
    src/sbbs3/getkey.cpp
    Log Message:
    Fix logged garbage observed in release rPi3 builds

    The "insert key into keybuf" log line could contain garbage. Apparently
    in a release build, the nested scope stack variable is actually invalid
    after the end of the scope. Weird.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Nov 22 15:30:20 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/94fe4232d00189c225b4fd1e
    Modified Files:
    src/sbbs3/getkey.cpp
    Log Message:
    Fix CID 469138

    getkeys() is actually never (currently) called with a NULL arg, so this
    could not actually occur, but better to prepare for that eventuality.

    This looks like a case of not following the YAGNI principle.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net